Laravel Code Review: Optimize Queries and Other Performance

Today I'm reviewing the Artisan command code that I received via email.
Related video. Laravel: Be Careful with whereHas Performance in Eloquent • Laravel: Be Careful wi...
- - - - -
Support the channel by checking out my products:
- My Laravel courses: laraveldaily.c...
- Laravel QuickAdminPanel: quickadminpane...
- Livewire Kit Components: livewirekit.com
- - - - -
Other places to follow:
- My weekly Laravel newsletter: us11.campaign-...
- My personal Twitter: / povilaskorop

[@codewithrex]

In my opinion you could also use ->lazy() instead of ->get() when querying the users - it sacrifices a runs a little bit slower for huge memory savings.

[@anesu6184]

The only addition I would do is add pagination logic so that if I have many employees the command will continue working without any changes.

[@jmyers2896]

It would be good to run explain on the raw sql queries and checking for any full table reads. Then add indexes as needed to optimize those queries.

[@jcc5018]

so your part about caching the date I would never have thought of. Mainly cause I haven't thought about caching at all as Im still trying the get the other parts figured out. But I always assumed I would eventually just set up caching for whole pages that dont have to change all that often. I never really considered caching small pieces of data like this for optimization. So if you dont already have a video on this, perhaps you could make one that could explain different scenarios in which various levels of caching would help optimize an application.

[@LaravelDaily]

Searched "caching" on the channel for you: www.youtube.com/@LaravelDaily/search?query=caching

[@jcc5018]

@@LaravelDaily Thanks, its not as easy to search individual channels on mobile, but I also am not really in need of the topic personally at this time, Just wanted to provide a suggestion since you have asked for video ideas before, and I know you cover topics in different ways at times as there are many different ways topics can be implemented. This video prompted a question I thought may be worth diving deeper into, so I offered the suggestion.
But i'll "cache" the response for future reference. I've got to go figure out how to use google ad manager

[@kingstalker]

Good quistion

[@erikguillen6599]

just learned bout it too

[@nsejanvier]

​@@LaravelDaily I want laravel 11 VS Flutterwave

[@ryiad2010]

This is very useful, thank you

[@timothybelekollie6461]

this is great sir, thanks for always enlightening us.

[@longingheart77]

I believe you can check if date is during the weekend via Carbon instance method

[@DeepStreamBits]

I only use model query if I actually want to get the model, otherwise I'm just doing a DB::table('***') query

[@BinaryKitten]

With the query change, you'll also need to update the data side as shift end_at won't be on a relation.

[@LaravelDaily]

Yes great point

[@TrueWebDev]

Hi, here could be a refactoring issue, "attendances" is HasToMany relation, so join can produce more than one user entity and we will get extra items in result $data array, this can cause data inconsistency or something else.

[@LaravelDaily]

Technically, you're right. But I guess those extra items could be identified and filtered out with where() conditions.

[@ZyronZA]

Why is this doing DB access and business logic in one function? How will you write tests for that command if you cannot mock the Holiday:: and User:: object, or even the business logic? What's the purpose of Day::sunday->name if it already has the name "sunday"?

[@LaravelDaily]

Valid points, making this artisan command testable would mean a strong refactoring. Maybe you would want to perform it? I would gladly shoot a video about it.

[@Theo-bz8kk]

You can still make feature tests for this command.

[@ZyronZA]

@@LaravelDaily Hey! I don't see the purpose a command having a test written for it as it's just to coordinate operations.
My thinking here is the business logic should be in its own class and injected into the command constructor. Then the Holiday:: + User:: object are injected into the business logic class.
A test is then written for the business logic class to lock down its functionality.

[@junjunghasudungan1905]

Hello sir,
User()->query()
The Meaning is instence to model user for elequent?
What a benefit to used?
Thanks for education us with this video

[@LaravelDaily]

This video is the answer: ruclips.net/video/yviVaX7-wT4/видео.html

[@bumblebity2902]

Is it big "NO" to use DB queries in helper functions or should I cache daily for example to convert currency?

[@LaravelDaily]

It depends on the situation, there's no single answer.

[@bc0078]

Very nice but shouldn't weekend be sunday and saturday?

[@LaravelDaily]

Not in all countries of the world

[@syracuse4612]

Nice🥰

[@mohammedattar3628]

i need to email your sir

[@-slash-7772]

Hi, I have a question about deleting "second degree relationships." Lets say I have a grandparent->children->grandchildren and when I delete a grandparent, my goal is to delete its children and grandchildren. I'm not sure if there is a good, standard solution, but here is ChatGPT's working solution:
// Grandparent.php (the function is utilized in the GrandparentController.php when deleting)
public function deleteWithRelated()
{
// Delete grandchildren
$this->grandchildren()->each(function ($grandchild) {
$grandchild->delete();
});
// Delete children
$this->children()->each(function ($child) {
// Delete children
$child->delete();
});
// Finally, delete the grandparent
$this->delete();
}

[@LaravelDaily]

I would personally do it on the database level, in migrations: $table->foreignId()->constrained()->cascadeOnDelete();
But if you don't have that in the database, then yeah, I guess ChatGPT solution is ok.

[@LaravelDaily]

Following up, I've just published this tutorial.
Laravel Parent Children and Grandchildren Delete: Three Options
laraveldaily.com/post/laravel-parent-children-grandchildren-delete-records