So much this... I've been doing Software Dev for 26 years, PHP for 16 years, and Laravel for the last 2.5, and I learned something from this video. So I'd also add "Seniors, don't assume you know everything, and your way is the only way."
The delete action using "GET" instead of "DELETE" might expose the user to CSRF attacks. That one should be changed for security. (I hope this observation can be useful for someone).
@@digitalminister5687 Yes, I know, I just wanted to point out the potential security issue, that's all :) I also record videos and it's challenging if not impossible to cover everything in one video no matter the length.
i agree with you on this statement "as junior dont be afraid to make mistake (but take responsibilty on that)" "as senior dont attack your junior (we have to start somewhere right)" huge respect to you!!
Im experienced web developer, but a c# one. Have no idea why this video appears in my recommendation, but it's ASWESOME. For me It was a good overview of PHP/Laravel development). Without any experience I understood 100% of it! Thanks.
This means a lot of helpful to jr. developers to learn. I have seen many videos. many of video creators Assumes that you were aware about the mistakes that users do. but actually the fresher or junior developer wasn't aware of that. *And this is really fantastic video to identify mistakes and correct them*.
The command in PHPStorm to highlight the next occurrence of a word is Ctrl+G on Mac and Alt-J on windows. On vscode it’s ctrl+D. Rather than moving the mouse and highlighting line by line Great content!
Hello sir You are the most humble and kind person in the region. You always appreciate others for working hard instead of dominating them for mistakes, and helping them grow each time. I think your contribution to this growth of laravel is remarkable. Help is only help, whatever form it may be given, and I am grateful for your efforts and love.
I have completed my last project fully with query builder only. This video help me to under stand the standard of code. Thank you so much sir. You videos help me lot
Very nice sir, most of the tutorials on net only deals with beginners things, ie how to start or more advance things, but you literally deal with minor problems which developers actually face, while developing something. I highly respect you for your efforts.
@@mbparvezme Validation messages can be set in the Request Class created using " artisan make:request" command. Laravel will take care of the rest. And for the frontend you do everything same as before. Also check out the laravel documentation on "The Basic > Request" section it explains it beautifully. You can also use custom Rules inside the request class instead of if statements in the controller. 😉
@@0xshashwat Thank you for your reply. It was my fault. I just forgot to include the "Accept: application/json" header in the request. That is why it send me a response with a redirect (back). But with the appropriate header, I got the error message.
Great video. As for multi-line edit. Just double tap ctrl, and use arrow down to select all lines. Hit "End" to get the cursor to the same location on each line. Now remove the middleware in one go.
Thanks for your videos Povilas, I am also beginner laravel Developer, i'm your fan, your videos are very helpful. When I start earning money i will obviously buy your " eloquent course"
Such a phenomenal idea for the video. This what I was looking for back when I started just a year ago. I always had a feeling that new/beginner developers want to see what a real application looks like, how every part of it looks like, not just some examples and basic principles. Or even see other beginners how they code and it all looks like. So interesting. I will admitted, I do have some mistakes in common with the "author" of the code you reviewed. You should keep doing videos like this, it's really useful in terms of improving and seeing that we all actually make common mistakes, I'm no different than many other guys who started. It's a normal learning process and we shouldn't be ashamed of our silly, but important mistakes. Really grate video sir. 🙂 Cheers
Well then.. This 'refactoring' went so fast, I felt bad I couldn't follow everything. Time to brush up on my Laravel skills again. Quality video by the way. THIS is how juniors improve and learn different code styles and refactoring.
Another note: if you're looking to refactor your routes, please take the time to make some quick feature tests that hit your routes so you can test when you change anything if something breaks and follow the errors to refactor it correctly.
Awesome video, happy to see that I'm doing at least some of the things right, but even happier to see what is expected from me to write a better code in laravel.
You really boost the morale for LARAVEL for all junior devs.
3 года назад+1
This video format is great for the channel as the comment/view ratio it gets. Some stuff is obvious but other is just awesome. Keep this series coming along.
Extremely helpful!! I started coding in Laravel a few months ago, and while I know how to get things done, this helped me learn how to do them the right way. Thank you!
Pretty good review. Only thing I would have said more explicitly is that Material:all() returns a collection, so the where is using PHP code to do its job. It may not be as obvious to the junior that the all() sets up the query AND fetches, where as the where function of the Eloquent model is simply utilizing a query builder and get does the fetch. The confusion mostly stemming from the collision of some function names in collections vs query builder for eloquent.
This chanel is gold... Great video, as always 🔥 For this code review, I would also go for constants, instead of hardcoding Roles ID everywhere. Like ROLE_MEISTER = 0, and so on. Should make the code way more readable.
If a resource route was used you might also run into the issue of not all the routes expected being present, which very well might be intentional as you might not need all of them. They are; index, create, store, show, edit, update and destroy. If any are not needed you can chain the "only" or "except" methods when defining the route: Route::resource('photos', PhotoController::class)->only([ 'index', 'show' ]); or Route::resource('photos', PhotoController::class)->except([ 'create', 'store', 'update', 'destroy' ]); respectively. If a resource route is defined and all expected methods are not accounted for then artisan will throw an error. This is a great vid, just hoping to help out too if i can.
really incredible video quality, learning from your lessons constantly. At work, I recommend your videos to colleagues. Thank you for such quality content! hello from Russia, city of Stavropol: 3
Yeah, this one took longer time to produce than I expected. Started with idea that "I'll just give a few tips in 5 minutes", and published this video 4 hours later :)
In PHP Storm you can use "Alt+J" to select next occurrences of the selected code or use "CTRL+Shift+Alt+J" to select ALL occurrences of the selected code.
very very helpful sir you help me very much in laravel as i am also a laravel developer . Really thanks for your knowledgeful videos and keep ahead sir one more time thank you very much
Great video, need more of this unique learning, particularly useful for any dev level. Amazing advice to junior and senior at the video introduction. 👏
Great Video. I would love to watch more videos like this.
3 года назад+4
I think generally you learn more from just reading the documentation (for a junior dev). And secondly just debug through the framework code to understand it better and learn how to extend it to your advantage to reduce even more boilerplate code. Its a good quality video though and thanks for the timeline.
You helped me alot with the $requests... I did it the same way as you mentioned but i left it inside the function what felt tottaly wrong and now i know why i had this feeling all the time
Povilas, another great video. I can't get enough of praising and thanking him for his work. And I think your guidelines are not just for juniors! Congratulations!
Thanks. It was very helpful. A lot of tips that I think about every time when write code like "How to do in this situation" or "How it should be in correct way"?
At 9:30, i can see that the migration contains insertion operations I suggest moving those to a specific seeder class (e.g. RolesTableSeeder), because a migration isn't meant to seed database
"Juniors don't be afraid to show your code. Seniors don't attack the juniors that the code is bad. We all start somewhere."
So much this... I've been doing Software Dev for 26 years, PHP for 16 years, and Laravel for the last 2.5, and I learned something from this video. So I'd also add "Seniors, don't assume you know everything, and your way is the only way."
@@JimOHalloran Every day there is new oppurtunities to learn things, we shoudn't feel ashamed to do so !
Absolutely, thankfully my team lead adopts this mentality as well. Such a good quality to have in leadership and development in general.
I liked the video format. And today I noticed that I'm not a junior anymore.
Lmao
The delete action using "GET" instead of "DELETE" might expose the user to CSRF attacks. That one should be changed for security. (I hope this observation can be useful for someone).
buen dato , maestro.
3:54 he mentioned it
@@digitalminister5687 Yes, I know, I just wanted to point out the potential security issue, that's all :) I also record videos and it's challenging if not impossible to cover everything in one video no matter the length.
styde needs updated videos on laravel 8 ;)
John Smith what does that have to do with this video? And FYI I do have tons of videos in L8, just not in my RUclips channel.
Yes ! Please ! More code reviews videos ! As a junior I can't state how valuable this is. Thanks for everything !
Omfg. This is like those "very satisfactory" videos with people slicing colored clay, but with coding.
Such a rewarding feeling to watch.
i agree with you on this statement
"as junior dont be afraid to make mistake (but take responsibilty on that)"
"as senior dont attack your junior (we have to start somewhere right)"
huge respect to you!!
Im experienced web developer, but a c# one. Have no idea why this video appears in my recommendation, but it's ASWESOME.
For me It was a good overview of PHP/Laravel development). Without any experience I understood 100% of it! Thanks.
Your one video > Tones of Learn laravel from strach for Inermediates.Thank you Sir, have a better life everyday.
This means a lot of helpful to jr. developers to learn.
I have seen many videos. many of video creators Assumes that you were aware about the mistakes that users do. but actually the fresher or junior developer wasn't aware of that. *And this is really fantastic video to identify mistakes and correct them*.
The command in PHPStorm to highlight the next occurrence of a word is Ctrl+G on Mac and Alt-J on windows. On vscode it’s ctrl+D. Rather than moving the mouse and highlighting line by line
Great content!
Hello sir
You are the most humble and kind person in the region. You always appreciate others for working hard instead of dominating them for mistakes, and helping them grow each time. I think your contribution to this growth of laravel is remarkable.
Help is only help, whatever form it may be given, and I am grateful for your efforts and love.
I've never written a line in PHP but still watched till the end, you never know when you gonna need this.
Great review, very satisfactory.
I have completed my last project fully with query builder only. This video help me to under stand the standard of code. Thank you so much sir. You videos help me lot
after watching this video i’am not a junior developer anymore 😁 , more videos like this sir. this is awesome, thank you povilas ❤️
after 7 months of coding in laravel I finally got a hang of its basics... but this video shows me I just scraped the tip of the iceberg...
Very nice sir, most of the tutorials on net only deals with beginners things, ie how to start or more advance things, but you literally deal with minor problems which developers actually face, while developing something. I highly respect you for your efforts.
Eres grande amigo. No porque sepas mucho, sino por darte el tiempo de ayudar a los que saben menos. Saludos desde Chile.
That $request->validated() and $fillable combination was on another level. Got to learn something new 😄
@@mbparvezme Validation messages can be set in the Request Class created using " artisan make:request" command. Laravel will take care of the rest. And for the frontend you do everything same as before.
Also check out the laravel documentation on "The Basic > Request" section it explains it beautifully. You can also use custom Rules inside the request class instead of if statements in the controller. 😉
@@0xshashwat Thank you for your reply. It was my fault. I just forgot to include the "Accept: application/json" header in the request. That is why it send me a response with a redirect (back). But with the appropriate header, I got the error message.
i just watched till 1:13 and i start loving you.... This is how juniors shud be treated... Love You Sir.
Great video. As for multi-line edit. Just double tap ctrl, and use arrow down to select all lines. Hit "End" to get the cursor to the same location on each line. Now remove the middleware in one go.
or just hold alt as your move the cursor
Amazing concept! Please do as many videos as you can easily. This is great content. Keep up the awesome work. 👍👍👍
Thanks for your videos Povilas, I am also beginner laravel Developer, i'm your fan, your videos are very helpful. When I start earning money i will obviously buy your " eloquent course"
Such a phenomenal idea for the video. This what I was looking for back when I started just a year ago. I always had a feeling that new/beginner developers want to see what a real application looks like, how every part of it looks like, not just some examples and basic principles. Or even see other beginners how they code and it all looks like. So interesting. I will admitted, I do have some mistakes in common with the "author" of the code you reviewed. You should keep doing videos like this, it's really useful in terms of improving and seeing that we all actually make common mistakes, I'm no different than many other guys who started. It's a normal learning process and we shouldn't be ashamed of our silly, but important mistakes.
Really grate video sir. 🙂
Cheers
Well then.. This 'refactoring' went so fast, I felt bad I couldn't follow everything. Time to brush up on my Laravel skills again.
Quality video by the way. THIS is how juniors improve and learn different code styles and refactoring.
Another note: if you're looking to refactor your routes, please take the time to make some quick feature tests that hit your routes so you can test when you change anything if something breaks and follow the errors to refactor it correctly.
Awesome video, happy to see that I'm doing at least some of the things right, but even happier to see what is expected from me to write a better code in laravel.
I really enjoyed and learned watching this one as a junior programmer!
Please make this into a more regular series, very helpful! Thank you.
Love code reviews like this! Please do more. It's a great way to learn. Thanks!
I haven't done Laravel in years, but it was still interesting to watch :-)
Liked this video? I have many more: subscribe to my 30+ Laravel courses laraveldaily.com/courses
It helps us a lot as a junior Dev. please keep Reviewing .
You really boost the morale for LARAVEL for all junior devs.
This video format is great for the channel as the comment/view ratio it gets. Some stuff is obvious but other is just awesome. Keep this series coming along.
Extremely helpful!! I started coding in Laravel a few months ago, and while I know how to get things done, this helped me learn how to do them the right way.
Thank you!
Cool video concept. Definitely do more of these as they’re interesting. I learnt a few things too 🥳
Thanks , boss these kind of videos have great tricks... we need more and more
This is really great, thank you. It's embarrassing to me that you probably just wrote more code in 20mins than I wrote all day today.
Loved your disclaimers!! Great video! Thanks for sharing. I'm also a junior developer and learning a lot from your videos.
Pretty good review. Only thing I would have said more explicitly is that Material:all() returns a collection, so the where is using PHP code to do its job. It may not be as obvious to the junior that the all() sets up the query AND fetches, where as the where function of the Eloquent model is simply utilizing a query builder and get does the fetch.
The confusion mostly stemming from the collision of some function names in collections vs query builder for eloquent.
Great video, love the format. Never knew about the eloquent "when" method. Good way to plug gaps in your knowledge
Refactoring is like ointment for my soul. I don't even use php but this is such a great idea for youtube content.
I am new to Laravel and some of these things are how I coding with Laravel, some are new and I'm excited to get more.
This chanel is gold... Great video, as always 🔥
For this code review, I would also go for constants, instead of hardcoding Roles ID everywhere. Like ROLE_MEISTER = 0, and so on. Should make the code way more readable.
I don't even know what the heck Laravel is, but that is a neat video format.
🥺
As a web developer in 2021, If you really don't know what Laravel is, you have a problem buddy!
If a resource route was used you might also run into the issue of not all the routes expected being present, which very well might be intentional as you might not need all of them.
They are; index, create, store, show, edit, update and destroy. If any are not needed you can chain the "only" or "except" methods when defining the route:
Route::resource('photos', PhotoController::class)->only([
'index', 'show'
]);
or
Route::resource('photos', PhotoController::class)->except([
'create', 'store', 'update', 'destroy'
]);
respectively.
If a resource route is defined and all expected methods are not accounted for then artisan will throw an error.
This is a great vid, just hoping to help out too if i can.
Thank you this was awesome! As someone just refreshing their Laravel knowledge I learned so much
really incredible video quality, learning from your lessons constantly. At work, I recommend your videos to colleagues. Thank you for such quality content!
hello from Russia, city of Stavropol: 3
Please make more videos like this!
I loved to check what I am doing wrong and how to fix it and make it a better code !
Wish I could like this video 10x. What a great tutorial
Wow, I don't even code in Laravel but I couldn't stop watching. I wish there was something like this for code in Ionic, Angular, Vue or Firebase.
We need more this type of videos. Thank you.
Can you please make more refactoring videos like this? please!! It was soo good!
I was just checking about Today's video 5 minutes ago 😁. Now here it is. Thank you Povilas.
Yeah, this one took longer time to produce than I expected. Started with idea that "I'll just give a few tips in 5 minutes", and published this video 4 hours later :)
Laravel daily sir, it help us alot because we are junior
yes please do more refactoring session. Thank you!
Nice video and so many tricks and advises in just 20 minutes. Thanks
In PHP Storm you can use "Alt+J" to select next occurrences of the selected code or use "CTRL+Shift+Alt+J" to select ALL occurrences of the selected code.
Best and crystal clear tutorial, thanks a lot 🙏
Thanks alot Sir
This video is just so golden for me
Will sure watch more of this kind of your videos 🔥🔥🔥
Thank you for the video. We need more like this. Keep it up!
Thank you so much.. You are doing great things for beginners... Keep it up
Hope this series got more video. very helpful for all. thanks a lot.
Awesome video, perfectly explained, easy to understand, high value tips
Nice video, very helpful for junior laravel devs
Details that can simplify your life a lot!
very very helpful sir you help me very much in laravel as i am also a laravel developer . Really thanks for your knowledgeful videos and keep ahead sir
one more time thank you very much
Keep it up sir. I always wait for your videos. I learnt more things in laravel.
More of this, please! I am just starting in the laravel world :D
we need more videos like this .thank you for this video
I don't even code on PHP but I enjoyed the video, mostly for the lessons on organization and cleaner code.
Great video, need more of this unique learning, particularly useful for any dev level. Amazing advice to junior and senior at the video introduction. 👏
Please create more videos like this. This is so helpful.
Thanks a lot . Please , make more video like this. It's very educative.
This was really great, had to pause a lot to think... :). Really useful to see.
I just learned how to use in_array, thank you very much :)
Me too
the "store" method review i like the most
Great video,we need more videos like this
Great Video. I would love to watch more videos like this.
I think generally you learn more from just reading the documentation (for a junior dev). And secondly just debug through the framework code to understand it better and learn how to extend it to your advantage to reduce even more boilerplate code.
Its a good quality video though and thanks for the timeline.
thx povilas, really awesome, we want more and more videos like this videoo
Awesome! Really really great idea for video. Practical examples...
Very cool how you give tutorial, thanks for the video man!
big thanks for you , you are the best in youtube truly
You helped me alot with the $requests... I did it the same way as you mentioned but i left it inside the function what felt tottaly wrong and now i know why i had this feeling all the time
need more like this. Code Review. Thanks for this share
I love these , I hope you still make them
I've made a lot of them, until I started repeating myself. See the Playlists of the channel, there should be one with reviews
Thank you teacher .. please do this more
useful, its always nice to watch videos like that one
Povilas, another great video. I can't get enough of praising and thanking him for his work. And I think your guidelines are not just for juniors! Congratulations!
simply, LEGEND !
Thanks, I learned a lot ...
This tutorial is very helpful!
Thank you so much!
Thanks. It was very helpful. A lot of tips that I think about every time when write code like "How to do in this situation" or "How it should be in correct way"?
wow , it's amazing , thank you very much , I got a lot of information in this video
At 9:30, i can see that the migration contains insertion operations
I suggest moving those to a specific seeder class (e.g. RolesTableSeeder), because a migration isn't meant to seed database
Thank You. Very good tips for beginners. I learn daily really :)
Bravo! what a great video, I've learned a lot, thank you Sir, keep it going.
This is very helpful. Maybe it can be new video series...
You are doing nice work in this video. I like it
your youtube channel is very informative
Thanks for the wonderful video.what I have been looking for.
Awesome explanation.