Fix a memory leak in Flutter (

We fix a memory leak in the Flutter framework. This work was brought to you by my GitHub sponsors. Please consider becoming a monthly sponsor, too! github.com/sponsors/matthew-c...
✪ Start a bounty 👉 flutterbountyhunters.com
✪ Say, Hi 👉 / flutterbounties

[@abdullahalamodi5455]

this is really next level of tutorials, keep it up, thank you .

[@aytunch]

Perfect real time contribution from investigation to PR. You deserve to be sponsored by many more of us!

[@mkc11267]

Learned a lot! I hope I which I could sponsor you but I currently have no work lol. But please continue publishing videos including in your other channel. Your contents are literally diamonds in flutter community.

[@theGoldyMan]

I felt like Mr Carroll was at the bring of saying some slurs. I was at least. That was a good experience watching this process. Decoding the source of some part of flutter is just madness, I feel we are missing a huge chunk of information about the context in which this feature was developed. Wasn't there a design doc? You have my respect since the times before you deleted your flutter challenges, I miss them so much. Keep up the good work. Thanks a lot for this video.

[@Elguri-yk7rb]

I want to see more of this kind of educational videos

[@verticrow]

Really awesome to see the whole process! Thanks for all that you do.

[@AkashSingh-cr7ly]

That's awesome work you are doing, lots of learning here, keep it up.

[@abdushakoor0099]

This was so cool to watch.

[@mboyamichael7618]

Great Work!

[@mattlampe]

This was very cool to watch, I've made some contributions to packages I've changed/fixed before and that always feels really cool, but this made fixing something in the flutter framework feel more approachable as it always seemed so daunting before. Thanks for making this video!

[@ferekfrankburt]

Выглядит вроде как не сложно

[@ShawnBlais]

Seems like you just didn't register that value is a `ValueNotifier` and it's updated in `onTriggered`. So it's totally expected that you couldn't find anywhere where it updates the value internally. By design it defers to `onTriggered` to set the value, and the widget uses `notifier.addListener` to act on those changes.

[@kishandhankecha]

#136245 Could this be the second fix?

[@FlutterBountyHunters]

Maybe. Navigator is a big mess. It has lots of problems and they touch a lot of places. Is this a problem that's holding you back?

[@britannio]

Could you use git interactive staging (git add -p) to avoid committing the formatting changes?

[@britannio]

Or just the IntelliJ git diff UI.

[@FlutterBountyHunters]

Yeah both of those would probably have worked. But I never use those tools so I'd have to deal with the learning curve there first.

[@StingSting844]

Good stuff🎉. I think it would be great if talking about the person who contributed to the bug was avoided. Doesn't help the content in anyway

[@joe5head]

When did this happen? Unless I missed it the feeling I got was talking about the code !== Talking about the person who wrote the code. Saying why a certain line should not exist or is bad !== Saying the same about the person who wrote the line
I think the critical parts of the video have the most potential for insight but can also see that frustrations/rants can be easily misinterpreted

[@FlutterBountyHunters]

As you say, no names were named. Except I said that Taha and Justin are usually helpful with PR reviews.
When it comes to the code, if we don't acknowledge problems and poor decisions then no one will ever think to change their approach. And if I don't tell the audience that something is a problem, then the audience might start contributing to Flutter and do more of it!