Nice video, I follow these in general - First understand what purpose does this PR solve? - Wether all test cases are written? - Syntax wise if there is integration with CI pipeline? - Code coverage - All external or io calls should handle exceptions - Critical Info which may be required during p0 is logged? - Is code simple? - Can it refactored? - Does it violate any design priciples? - Be polite and respectful while proposing suggestions? - Appreciate good things that is done 👍
Great video, thanks ! I like how you share the tips which reminds us working with empathy as well as what to share to the other person so that the workflow can be less stress and also more rewarding for both parties.
Nice video, I follow these in general
- First understand what purpose does this PR solve?
- Wether all test cases are written?
- Syntax wise if there is integration with CI pipeline?
- Code coverage
- All external or io calls should handle exceptions
- Critical Info which may be required during p0 is logged?
- Is code simple?
- Can it refactored?
- Does it violate any design priciples?
- Be polite and respectful while proposing suggestions?
- Appreciate good things that is done 👍
Helpful advice, Tom! SO much empathy! Thank you for sharing.
Great video, thanks ! I like how you share the tips which reminds us working with empathy as well as what to share to the other person so that the workflow can be less stress and also more rewarding for both parties.
that was really helpful. thanks for sharing
Great video!
Thank you!