Thanks for making this video. I am gonna show it to my colleagues because you explain the heart and spirit of code reviews so much better than I can possibly do it. =^,^=
This video has some psychological insights and tips that aren't mentioned in other similar videos. Smart/wise and super useful. Thanks for those too, man!
I really enjoyed the video! I don't know what's your company's policy on who reviews which code, but I found that if you can choose, people tend to choose good reviewers over bad ones who just approve the changes :) When code reviewing, what do you do if you find some code that isn't in the patch but doesn't comply with your quality standard? Do you comment on it for the author to fix it on the same PR or would you just create a task to work on it later? Thanks for the video!
Changes should be related to what is in the commit one way or another - I'd suggest another review if something important isn't fixed. Otherwise - don't fix stuff that isn't broken.
exactly - I prefer my concrete colleague who almost always suggests changes and improvements and basically teaches me over the other colleague who just approves whenever there aren't obvious bugs or code smells
I’m working Towards my bachelors in computer science and have 2.5 years left in my program hopefully specializing in block chain technology . Watching your videos are extremely motivating
Do you should run and test the changes as a reviewer? Like a whitebox test? We have a testing phase, but this is only blackbox integration test. I experience many pull requests that have unittests with their commit, but when I do an integration test manually the change doesn’t even work 100%. Any suggestions?
CI pipelines are the only way to go. You need all tests being automatically run as you make your commits to the repository. Look at things like Jenkins, Gitlab CI, Travis or any other tool like that.
Great tips ! Smok, could you please make a video of how we use advanced data structures and different Algorithms in daily tasks in "Big Companies" , this could be possible ? I know that FAANG companies hire Engineers who have a high understanding of DS and Algorithms Can a junior engineer join these companies ? can I dream of something like this ? as a Senior Engineer, what do you expect from me to know and understand while making an Interview for me. Sorry for my strange questions, hope you are fine with them :) Your help is highly appreciated, thanks in advance
Every job description has some requirements - depending on the position I would expect different things, but basic CS skills are a must for everyone in tech world. I wouldn't expect advanced stuff from beginners, but data structures and algo is daily bread and butter, so you need to know them.
Code reviews have a tendency to become toxic and are often used as a weapon to attack the developer rather than educate. It's my opinion that code review is taken too seriously, its not as important as it’s made out to be. Instead of focusing on the nit-pick of the day, it would be more useful to run the persons code to check the work meets the functional requirements set out in the user story.
I can just say: I feel sad for your toxic environment. Good educative comments can quickly boost your code quality, as you will think of them before posting a CR, and produce better code to begin with.
Thank you for your simple English. I can understand everything.
full, beginning, comments, summary, approval or rejection
polite
„I think you forgot G” - That's what she said. Michael Scott would say 🤣 Congrats on reaching 10k subs. Your channel is really amazing ❤️ Respect!
Thanks for kind words. You're not doing so bad yourself, Mr. Good Times New Roman! Not bad at all...
I don't need any code review, I know my code sucks.
MrKret87 the author explained the code review will help you learn to code better :)
Great Video with great tips. Being nice is an often overlooked superpower.
Thanks for making this video. I am gonna show it to my colleagues because you explain the heart and spirit of code reviews so much better than I can possibly do it. =^,^=
Such a detailed and enjoyable video! More people need to watch this
This video has some psychological insights and tips that aren't mentioned in other similar videos. Smart/wise and super useful. Thanks for those too, man!
I like the tips about good comments, Good stuff!!
I really enjoyed the video!
I don't know what's your company's policy on who reviews which code, but I found that if you can choose, people tend to choose good reviewers over bad ones who just approve the changes :)
When code reviewing, what do you do if you find some code that isn't in the patch but doesn't comply with your quality standard? Do you comment on it for the author to fix it on the same PR or would you just create a task to work on it later?
Thanks for the video!
Changes should be related to what is in the commit one way or another - I'd suggest another review if something important isn't fixed. Otherwise - don't fix stuff that isn't broken.
exactly - I prefer my concrete colleague who almost always suggests changes and improvements and basically teaches me over the other colleague who just approves whenever there aren't obvious bugs or code smells
Great video and excellent tips for writing code reviews.
very useful video!
Thanks
No problem!
I see what did you do there 02:53 LOL!
Great video!!!
simple and efficient
I’m working Towards my bachelors in computer science and have 2.5 years left in my program hopefully specializing in block chain technology . Watching your videos are extremely motivating
Do you should run and test the changes as a reviewer? Like a whitebox test? We have a testing phase, but this is only blackbox integration test. I experience many pull requests that have unittests with their commit, but when I do an integration test manually the change doesn’t even work 100%. Any suggestions?
CI pipelines are the only way to go. You need all tests being automatically run as you make your commits to the repository. Look at things like Jenkins, Gitlab CI, Travis or any other tool like that.
@@SmokCode we have CI in place, but those tests run only for the master branch.
@@robinbouwmeester4303 it's a matter of config then
Nice!
where can I get that mechanical keyboard?
nice explanarion
3:00 the most ridiculous part, is this about video editing or code review? :)
2:53 - 3:02, THIS SUCKS!!!!! 😂😂😂😂 , i thinks that is a way better comments
What keyboard is that?
Cheap mechanical amzn.to/35cjSag but has custom keycaps amzn.to/3aOBABU that give it this awsum factor.
2:55 ROFLMAO moment... 🤣 LGTM! 👍
Great tips !
Smok, could you please make a video of how we use advanced data structures and different Algorithms in daily tasks in "Big Companies" , this could be possible ?
I know that FAANG companies hire Engineers who have a high understanding of DS and Algorithms
Can a junior engineer join these companies ? can I dream of something like this ?
as a Senior Engineer, what do you expect from me to know and understand while making an Interview for me.
Sorry for my strange questions, hope you are fine with them :)
Your help is highly appreciated, thanks in advance
Every job description has some requirements - depending on the position I would expect different things, but basic CS skills are a must for everyone in tech world. I wouldn't expect advanced stuff from beginners, but data structures and algo is daily bread and butter, so you need to know them.
Code reviews have a tendency to become toxic and are often used as a weapon to attack the developer rather than educate. It's my opinion that code review is taken too seriously, its not as important as it’s made out to be. Instead of focusing on the nit-pick of the day, it would be more useful to run the persons code to check the work meets the functional requirements set out in the user story.
I can just say: I feel sad for your toxic environment. Good educative comments can quickly boost your code quality, as you will think of them before posting a CR, and produce better code to begin with.
When people understand that code review is just a tool for teaching to write better code is awesome.