How to review someone else's code

Поделиться
HTML-код
  • Опубликовано: 18 дек 2024

Комментарии • 28

  • @benzflynn
    @benzflynn 3 года назад +13

    *Reasons For Code Reviews*
    1. To ensure consistent application of best practice in coding throughout the group/organization.
    2. To explain each team member's code to all others: team members get better vision of entire system.
    3. To avoid over-dependence on group leader for system overview or integration bugs.
    4. To provide basis for discussions on code between team members so as to stimulate new ideas.
    5. To avoid coder's blind spot, i.e. inability of authors to see their own coding limitations or biases.
    6. To reach a more objective idea of code readability. What's clear to one coder may not be to others.
    7. To amend inadequate tests for the code.

  • @ChrisAthanas
    @ChrisAthanas Год назад +1

    6:26 bike shedding is not nitpicking
    It’s making suggestions that are “At least something” but not actually helping improve the core solution
    Basically instead of addressing an actual problem, make suggestions that take the project in a different direction
    Suggesting technical changes that do not address the actual problem
    Seeing all problems as nails when you are an expert at hammering kind of thing

  • @danilocecilia7831
    @danilocecilia7831 3 года назад +3

    After my third video looking for a concise explanation on best practices for code reviewing , I can say you got to the point right away and really well explained, thanks for this!

  • @akovac35
    @akovac35 3 года назад +2

    Yes, the communication part is very important (2 and 5)!

  • @lindasmith3978
    @lindasmith3978 3 года назад +5

    thank you for this! I am a Codecademy FSE student, currently at 20%

  • @mahmoudtaher5588
    @mahmoudtaher5588 Год назад +1

    I think that you meant `Increase Bus Factor` instead of `reduce buss factor` !! Am I missing something ?

  • @nargeshaeri7028
    @nargeshaeri7028 Год назад

    Thank you for sharing such nice tips on code review.

  • @PierreLaBaguette
    @PierreLaBaguette 3 года назад +1

    Very informative and clear video, thank you very much for this!

  • @vickyanand6483
    @vickyanand6483 3 года назад

    Just wanted to have an insight . What ate the most common problems/mistakes are pointed out by reviewers I have just got to check null pointer exception

  • @hertechera
    @hertechera 10 месяцев назад

    Thank you

  • @b4rt1j1
    @b4rt1j1 2 года назад

    The level of sus when boss requests code review from junior 🧐

  • @TyrellJoanna
    @TyrellJoanna 5 лет назад

    Thank you!

  • @hisfluffinessscaredy-catth9862
    @hisfluffinessscaredy-catth9862 5 лет назад

    Thanks!

  • @JacintaDejohn
    @JacintaDejohn Год назад

    important thnks

  • @sjsamphex
    @sjsamphex 3 года назад +1

    Please add CC for deaf viewers

  • @armkiller2011
    @armkiller2011 3 года назад

    thanks

  • @StrangeIndeed
    @StrangeIndeed 4 года назад

    thank U

  • @TheBongoZeptobrewery
    @TheBongoZeptobrewery 3 года назад

    Philly

  • @tamilmaranc
    @tamilmaranc 4 года назад

    great

  • @imjeffreylee
    @imjeffreylee 3 года назад +1

    this code sucks lol

    • @notmemes
      @notmemes 2 года назад

      ur mum sucks

  • @Jonathan-hl5il
    @Jonathan-hl5il 6 лет назад +1

    I'm trying to learn HTML and CSS.

  • @lanyado98
    @lanyado98 4 года назад

    Thank you!