An Interesting Redirection Bug. How Redirection Can Change Program Behavior.

Поделиться
HTML-код
  • Опубликовано: 3 дек 2024

Комментарии • 55

  • @unperrier5998
    @unperrier5998 2 года назад +22

    Nice bug to demonstrate. And it's nice to be able to redirect directly from gdb as well. Thanks!

  • @lean.drocalil
    @lean.drocalil 2 года назад +2

    There's always highly valuable stuff from this channel. Again, this is spot on👌

  • @neerajkale
    @neerajkale 2 года назад +7

    At the start of the video I assumed the seg fault has something to do with "> out.txt" been treated as 2 arguments to the program in argv[] 😅😅😅😅
    As usual learnt something new again from this channel. 😇

  • @ranchu3203
    @ranchu3203 2 года назад +1

    I didn't expect this. So basically, if I am understanding this right, the OS trying to "optimize" with more data being buffered leads to the segfault. Interesting. Oh well you learn new things every day.
    Great video

    • @MarekKnapek
      @MarekKnapek 2 года назад +1

      Not the OS, but the C language run-time.

  • @peterg76yt
    @peterg76yt Год назад +1

    The bug is the bug you deliberately wrote in the fake allocation routine. Redirection is working exactly the way it's supposed to. I'm pretty sure I remember that in the documentation on the standard file descriptors.

  • @SourabhBhat
    @SourabhBhat 2 года назад +18

    How does the program know that its std output will be redirected by the OS? That seems a bit strange! I thought redirection is done by the OS or the terminal.

    • @mikes9016
      @mikes9016 2 года назад +1

      Good question, I wonder as well.

    • @JacobSorber
      @JacobSorber  2 года назад +21

      Honestly, I don't know. Never dug that deep. But, now, of course, I need to find out. If the answer is interesting, then maybe it'll show up in a future video.

    • @mikes9016
      @mikes9016 2 года назад

      @@JacobSorber thanks 👍

    • @csbnikhil
      @csbnikhil 2 года назад +3

      A nitpick. A terminal has nothing to do with this. It just renders text on the screen. What you probably meant was a shell.

    • @tacokoneko
      @tacokoneko 2 года назад +1

      i think the program has undefined behavior so until it executes it is in a superposition state where it could either work perfectly or do something completely random and the decisions the operating system makes about where to allocate memory for the program at the moment it is called are having an effect on this balance. so in brief i think the operating system is influencing whether the segfault occurs not the program itself, the program is only providing the undefined behavior

  • @KevinInPhoenix
    @KevinInPhoenix 2 года назад +11

    If you write a custom memory allocator and don't test it with small and large values then you are not done yet. Inadequate testing is the root of all evil.

    • @fburton8
      @fburton8 2 года назад +3

      And zero and negative memory sizes and different sequences of allocations and... Something as low-level as a custom memory allocator needs to be tested up the wazoo (unless you don't mind random seg faults and futzing around with gdb).

    • @unperrier5998
      @unperrier5998 2 года назад +2

      I thought it was premature optimization that was the root of all evils. Maybe things have changed :)

    • @JacobSorber
      @JacobSorber  2 года назад +3

      So many roots of all the evils. :)

    • @Takyodor2
      @Takyodor2 2 года назад

      @@JacobSorber All -roads- roots lead to -Rome- evil!

  • @hashinggz
    @hashinggz Год назад

    stderr is not buffered, and back in the day when I learned about it, big deal, performance. Now I know. thank you again!

  • @reptilicusrex4748
    @reptilicusrex4748 2 года назад

    Thanks, very interesting and learned a couple gdb features as well.

  • @razu1976
    @razu1976 2 года назад

    This is a lesson dressed up as related to redirection, but is in fact SUSPECT ANY DIFFERENCE when things go a bit weird 😅 Cool drill-down to the details 👍👍👍

  • @edgeeffect
    @edgeeffect 2 года назад

    That's fascinating.... a bug that "can't possibly exist".

  • @andrewnorris5415
    @andrewnorris5415 2 года назад

    Like an airline pilot practices checklists in simulators for when things go wrong. So we should practice debugging skills. You never know when they might be needed and would save a ton of time when we need it most and make meeting critical deadlines possible.

    • @andrewnorris5415
      @andrewnorris5415 2 года назад

      Imagine if a critical random bug appears in released code. Would fix it much quicker and with fewer headaches than if all your skills were was print debugging.

  • @will_i_craft5555
    @will_i_craft5555 2 года назад +1

    I’ve seen that curl changes it’s behavior when redirecting (printing progress to stderr). Is it detected with a similar behavior there?

    • @kebien6020
      @kebien6020 2 года назад +1

      It probably uses isatty(3)

  • @tacokoneko
    @tacokoneko 2 года назад

    i have arch linux with kernel 5.16 and the program behaves exactly the same on my system, i was also unable to find any arguments for gcc or clang that could change the result. however i wonder if it is possible to create an environment where the program always segfaults or never segfaults, or segfaults without redirection some of the time but not all of the time

  • @benjaminshinar9509
    @benjaminshinar9509 2 года назад

    how did you make the program use the custom allocator? can you share the compile/link command from the makefile?

    • @JacobSorber
      @JacobSorber  2 года назад +1

      Just link the function in with the program. Either include it in your .c file, or compile it in a separate .o file and then link them together. It will use your malloc first before looking for one in libC. And, of course, you can do this at runtime using a shim, as well.

  • @rkroshan1997
    @rkroshan1997 2 года назад

    Awesome learning

  • @adrianojordao4634
    @adrianojordao4634 2 года назад

    Probably there is a vdu that explains the need to do custom alocators. I fully respect your programing skils, but this i miss. And wy 1k alocation is enauff?? Very cool but i feel that i m missing the point. Cheers

  • @wojcieszekk8581
    @wojcieszekk8581 2 года назад

    I wonder what functions did your students use? If have written an allocator for my operating system classes and i used sbrk. Is it better to use mmap or sbrk?

    • @BoundedByte
      @BoundedByte 2 года назад

      Just commenting in here so I can learn too-I usually wouldn’t use mmap for this sort of thing. I prefer it for buffering very large file I/O, whereas sbrk is appropriate for custom allocators since that’s usually what malloc is going to actually use in the first place. But if those assumptions are flawed or wrong I’d love to be corrected

    • @wojcieszekk8581
      @wojcieszekk8581 2 года назад

      @@BoundedByte I saw mmap implementations and I was just curious what is Jacob's recommendation for this. My requirement was to use standard sbrk. I was wondering what are the differences and what are his requirements for students and how different are my classes compared to his 😀

    • @JacobSorber
      @JacobSorber  2 года назад +4

      I don't know that it really matters. I often have my students use mmap, because then it doesn't interfere with the built-in allocator (which uses sbrk). But, you can definitely use either. Both are just mapping memory for you.

    • @wojcieszekk8581
      @wojcieszekk8581 2 года назад

      @@JacobSorber Thank you 🤎

  • @genz01234
    @genz01234 2 года назад

    Nice Practice.
    Although the bug is created by self(customized allocator).😂
    It's good to know "redirect" will also use malloc() to create a buffer for output.

  • @HansBezemer
    @HansBezemer 2 года назад

    Never knew that! But I can fully imagine you were scratching your head when seeing this behavior with your own eyes!

    • @JacobSorber
      @JacobSorber  2 года назад +1

      Yeah, it definitely took a few moments.

  • @ghostfjdgcsusvsgsj
    @ghostfjdgcsusvsgsj 2 года назад

    Never knew Mathew McConaughey could teach programming...

  • @i007c
    @i007c Год назад

    make your intro 5s so when we seek once its complitly seeks the intro

  • @alexisrodriguez7127
    @alexisrodriguez7127 2 года назад

    Wow super cool and weird

  • @YannAriell
    @YannAriell 2 года назад +1

    Nice video , but , how to include a function c++ in c

    • @yellowkll2853
      @yellowkll2853 2 года назад

      write a wrapper

    • @YannAriell
      @YannAriell 2 года назад

      @@yellowkll2853 Yeah but he dsn't work

    • @yellowkll2853
      @yellowkll2853 2 года назад

      @@YannAriell do you know how to compile source files into object files, and then link the object files together?

    • @YannAriell
      @YannAriell 2 года назад

      @@yellowkll2853 not too much but I know how to include C files in cpp

    • @yellowkll2853
      @yellowkll2853 2 года назад

      @@YannAriell ruclips.net/video/2YfM-HxQd_8/видео.html