Refactoring real-world Laravel app. Who wrote THIS CODE?!

Поделиться
HTML-код
  • Опубликовано: 25 янв 2025
  • НаукаНаука

Комментарии • 28

  • @limitlesskode
    @limitlesskode Год назад +4

    The refactor when you delegated the user service instantiation to laravel was quite cool. I was manually creating these instantiations in the constructor body and I think I will refactor to your approach.

  • @Vitalii-m6r
    @Vitalii-m6r Год назад +2

    It's a very useful video! Looking forward to seeing more of these)

  • @natenatters
    @natenatters Год назад +2

    I really like the refactoring videos! Nice job. Good to aim for the 80/20 rule too, you seem to get a lot of work done quickly!

    • @saaslaravel
      @saaslaravel  Год назад

      Thank you Nathan! I'm learning Vim so maybe I'll be able to push that speed even further 😊

    • @natenatters
      @natenatters Год назад +1

      @@saaslaravel Oh no 😆Im happy to watch you work in Vim, but I refuse to learn it as an IDE haha

    • @saaslaravel
      @saaslaravel  Год назад +2

      @@natenatters It's def challenging but that's what makes it fun haha :D

  • @mohammadashrafuddinferdous9347
    @mohammadashrafuddinferdous9347 Год назад +1

    At 8:24, UserService isn't the appropriate service class. It should be user order service if there are any other type of order services. Otherwise, user service will be a god service, sooner or later.
    And i think usrr service should always return user objects. It can be user model or dto or the collection of dto or user models. But when it returns anything else, it breaks the law of diameter.

    • @saaslaravel
      @saaslaravel  Год назад

      This project isn't super complicated and doesn't have loads of code, but if I was working on something more complex, I agree that UserOrderService is better

    • @mohammadashrafuddinferdous9347
      @mohammadashrafuddinferdous9347 Год назад

      @Przemysław Przyłucki Surely, if it's not complicated and only one person is working on it, then the path is ok to me too.

    • @mohammadashrafuddinferdous9347
      @mohammadashrafuddinferdous9347 Год назад

      @@saaslaravel I like you super simple dto btw.

  • @binaryfire
    @binaryfire Год назад +2

    Great video! What are your thoughts on actions vs services?

    • @saaslaravel
      @saaslaravel  Год назад +3

      I use actions as well - mostly when there a piece of logic that needs to be reused between different parts of the system, or when a service method has to interact with a 3rd party

    • @2gbeh
      @2gbeh 8 месяцев назад

      When to use Actions and when to use Traits ?

  • @akhileshkumar-iu9uq
    @akhileshkumar-iu9uq 10 месяцев назад

    Can u name the vscode extension which make ur code very real

  • @_bijaydas
    @_bijaydas Год назад

    I see you have a few Enums. What is preferred storing statuses for products, users etc. in Enums or in a table? I used to use Enums but now converted all status to status table.

    • @saaslaravel
      @saaslaravel  Год назад +3

      I use enums that cast to an int and just save the int in the db. This way I have nice type hinting in the app layer and can add more enums without having to alter db

    • @SilverPaladin
      @SilverPaladin Год назад

      @@saaslaravel I saw your Enum approach in another video and I love it! I hate having to touch the db to add or change the enums! I guess we could also add a layer on top of that for different languages?

  • @karlson2804
    @karlson2804 Год назад

    Very, very cool format, if possible, shoot more, please.

  • @carvalho1990
    @carvalho1990 Год назад

    Is there a repo for this code? Amazing! thanks!

    • @saaslaravel
      @saaslaravel  Год назад

      Unfortunately not, that's a private project

  • @gotoslovakia
    @gotoslovakia Год назад +1

    Great job. Thank you

  • @GergelyCsermely
    @GergelyCsermely Год назад

    Thanks

  • @Nodsaibot
    @Nodsaibot Год назад

    ANY php project that it requires use of the CLI means you are doing things WRONG, PHP was not created for this use environment

    • @SunilYadav-tm6kt
      @SunilYadav-tm6kt Год назад +1

      Not at all, its depends on requirement and use case

  • @khanra17
    @khanra17 4 месяца назад

    Why TF you decreased the pitch soo much ?
    these annoying youtubers, never gonna learn

    • @saaslaravel
      @saaslaravel  4 месяца назад

      That's how my voice sounds bud, it's just noice reduction + VO EQ, enjoy your day!

    • @jakubn3565
      @jakubn3565 4 месяца назад

      Agreed

    • @khanra17
      @khanra17 3 месяца назад

      ​@@saaslaravel
      No it's not.
      You never know your voice!
      Record someone you speak to in real life.
      Apply the same processing.
      And realize how far you are from a "human voice".