I think it’s great. I’d use a data object with typed values, and pass to the service. Also I’d dependency inject service with type, and call it service, not event ;)
Good job. Did you intentionally omit "ccURL" and "CCFullAddress" in the "$event->fill()" method to trigger me to add this comment? :D And there's a good idea to create a DTO instead of passing "$r->all()".
haha. Not really. I didn't think of it like this way. BTW, it's a very good point to consider DTO here. This would be an another way to make this code in more shape. Appreciated for your input. 👏
I think it’s great. I’d use a data object with typed values, and pass to the service. Also I’d dependency inject service with type, and call it service, not event ;)
Good work , Nice Code Review .
Thank you ❤
Awesome, thanks :)
Thank you 🥰
Awesome explanation! but how does your eyes survive with light mode? hahahahaa
Nice done
Good work, but why not use dependency injection and inject EventService?
Excellent.
I intentionally skip the DI for someone to spot the point and show me the right direction. 👏
Good job.
Did you intentionally omit "ccURL" and "CCFullAddress" in the "$event->fill()" method to trigger me to add this comment? :D
And there's a good idea to create a DTO instead of passing "$r->all()".
haha.
Not really. I didn't think of it like this way.
BTW, it's a very good point to consider DTO here. This would be an another way to make this code in more shape.
Appreciated for your input. 👏