Hey, good video. :) Some points from my side if I may: - The title is a bit "clickbaity"? As you're not building an OTP generator but rather using a dependency and implementing this usage within the application but I get it. ^^ - With your configuration and UI5 tooling version, the `ui5` key in the `package.json` is obsolete and shouldn't be used or recommended anymore. - I wouldn't bother adjusting the `afterTask` setup in your configuration and simply always put the ui5-tooling-module-middleware as last configuration option so the order in which they will be executed is always fine, also helps in not adjusting the `afterTask` for any additional configuration that may be added - After making use of requiring and injecting the dependencies appropriately I was a bit sad seeing the access to the JSON model via globals, but thats a minor thing - You shouldn't manually destructure the UI5 control object to retrieve the value via the properties but instead use its API methods like "getValue" These aren't major things and I know that you probably also know all of these but as this is a learning resource for many so I think it'd be important to note some of them or have them done differently in future videos (though this one is already 5 months old as of writing this comment so idk. how much that matters at all - the web moves fast!) Keep it up, love to see UI5 content! :)
Thank you for your detailed feedback. Yes things can be done always differently and always have a scope of betterment. Thank for watching and stay connected.
Hey, good video. :)
Some points from my side if I may:
- The title is a bit "clickbaity"? As you're not building an OTP generator but rather using a dependency and implementing this usage within the application but I get it. ^^
- With your configuration and UI5 tooling version, the `ui5` key in the `package.json` is obsolete and shouldn't be used or recommended anymore.
- I wouldn't bother adjusting the `afterTask` setup in your configuration and simply always put the ui5-tooling-module-middleware as last configuration option so the order in which they will be executed is always fine, also helps in not adjusting the `afterTask` for any additional configuration that may be added
- After making use of requiring and injecting the dependencies appropriately I was a bit sad seeing the access to the JSON model via globals, but thats a minor thing
- You shouldn't manually destructure the UI5 control object to retrieve the value via the properties but instead use its API methods like "getValue"
These aren't major things and I know that you probably also know all of these but as this is a learning resource for many so I think it'd be important to note some of them or have them done differently in future videos (though this one is already 5 months old as of writing this comment so idk. how much that matters at all - the web moves fast!)
Keep it up, love to see UI5 content! :)
Thank you for your detailed feedback. Yes things can be done always differently and always have a scope of betterment. Thank for watching and stay connected.
Thank you!
You're welcome!
Nice🎉