"I Lost a Job Because of This Codebase"
HTML-код
- Опубликовано: 19 июн 2024
- Use code GSBLAZOR20 at checkout to get 20% off our new Getting Started with Blazor course: bit.ly/4c9g8YA
Become a Patreon and get special perks: / nickchapsas
Hello, everybody. I'm Nick, and in this video, I will review a codebase that was submitted as a coding test for an interview and got destroyed by the interviewer for how bad it was. Was it really that bad?
Workshops: bit.ly/nickworkshops
Don't forget to comment, like and subscribe :)
Social Media:
Follow me on GitHub: github.com/Elfocrash
Follow me on Twitter: / nickchapsas
Connect on LinkedIn: / nick-chapsas
Keep coding merch: keepcoding.shop
#csharp #dotnet
I am a Tech Lead, and nit-picking like this is stupidity at best. I never expect an applicant to do the work exactly as I want it. My requirements are simple. Did the work satisfy the acceptance criteria? Is the code readable and does the project structure make sense? There is no need go into more detail as each team's way of doing things differ. The most important part for me is the attitude of the applicant, in other words, will I enjoy having the person a part of my team. The other smaller details can be sorted out when onboarding the applicant into the team.
Honestly I As a Senior Dev favor Putting everything in one Project for simple Projects structuring it with vertical folders
After 30 years doing this professionally, and writing code starting with 8 bit assembly language in 1982, my answer to any request for a "take home assignment" is "bite me".
If no one told you to create many projects and your application was rejected due to the lack of such a structure, you know that you have nothing to lose because you will not learn anything valuable in such a team.
After 25 years as professional developer, designer, whatever, if you give me home assignment that interview ends there. I do not work for free.
Hi Nick, I'd really like to see your implementation of this take-home assignment from scratch. I bet it would make a great video for all of us.
26 Year Software Engineer here... I have been hiring devs for the last 10 years. The artifacts in the repo is a deal breaker for me.
Why the hell would fluent assertions make any difference compared to built in xunit assertions?
I wish my coworkers in banking sector be able to write at least code like that
A lot of interview criticism is gatekeeping and pedantic behavior. Yes, the person should be able to code, but a lot of criticism is style cop BS. Each person, team, department, and company has coding and style conventions. Most of the time, the IDE or extensions will correct syntax or suggest naming. To think that a dev who codes to one convention that is different from yours is a failure is the reason that people have a distaste for the industry. Personally, I would not want to work with you. Does it work? Great! Fix the rest in code reviews and refactoring sessions. I actually have sympathy for the candidate who submitted this. How can he improve if he gets raked over the coals based on subjective nuance?
Alright, if Im ever fired from my current job im fucking cooked lmao
i think you judged many things that are 'opinions' and 'choices of preference' as absolutes, this is in my opinion a very bad way to do code review, as there was very minimal communication about the preferences.
I have hired lots of software developers, technical is usually a chat about coding , can pick up pretty quick if they know what they are talking about.
I had a similar situation once many years ago. I was asked to write an API with some endpoints and a database using any method I like. I thought to myself that they want to see if I truly understand how networking works so me coming from a broadcasting backend background I wrote a very low level API to show that I really understand how it all works. I was rejected and told that they wanted me to use Entity Framework and controllers. I was like why do you say any method if you expect me to use something specific not to mention that the way I wrote it really showcased my knowledge instead of just using frameworks which I could have done in 15 minutes. That day I learned to not be fancy because everyone wants to see the most mainstream solutions.
I've been developing for 15 years and I've worked from governmental to high demanding financial sector projects.
Interview: You are not doing it the correct modern state of the art way, like newtonsoft, who uses newtonsoft?
Sounds like this candidate should have just had ChatGPT write it. Utterly useless waste of time.
If you give me this task, then you need to give me a sample of your code base. I need to see what kind of mess you are asking me to come in to support.
More reviews please! That was quite interesting to watch.