Wrong document URL after parsing some HTML dynamically

Continuing the climb up mount WPT... Today we look at some failures under /domparsing where Flow is doing better than we are!
PR: github.com/Lad...
WPT dashboard: wpt.fyi/result...
Grafana: linegoup.lol/
Ladybird: ladybird.org/
GitHub: github.com/Lad...
Discord: / discord
I'm using the CLion IDE from JetBrains: jb.gg/clion_ak
My coding font is Berkeley Mono: berkeleygraphi...

[@pavelshlyak8385]

Could you make some code review videos so we understand the workflow, common mistakes etc?

[@rideorhitchhike3347]

It would be cool to have 👏 CODE 👏 REVIEW back.

[@corpseopera]

Pretty please!

[@colinstu]

Agreed!

[@DanielMircea]

I compiled lb, the other day. I tried a few websites, and just realized that I may have been their first Ladybird visitor ever. For whatever reason it felt nice 😅

[@metroid031993]

I think when you made the test, you forgot to pass the mimetype to parseFromString! Also, when checking for correctness, could you not verify that the URLs are the same? (Not super familiar with JS, but I'm pretty sure the original WPT test printed out the correct URL in the test results, which was working correctly)

[@awesomekling]

Yeah we should totally check that the urls are the same! I’ll make that edit when I’m back at the computer, great suggestion :)

[@morningsage5673]

I was just going to message about that bug. Thanks :)

[@avramitra]

These videos are extremely helpful and motivating for anyone interested to contribute to LB.
I am seriously considering to *try* to contribute, and it's mainly because of your videos.
Only 3 blockers are there:
1. My hectic schedule
2. My lack of advanced cpp knowledge. I'm only proficient in c.
3. LB's huge and sophisticated code base.
I hope I can start soon. This is a project which I deeply believe in, and want to be successful.

[@Bobbias]

Diving into this codebase would be a good way to get a feel for modern C++ in a fairly high quality codebase. Sparse documentation, except for the web standard docs they use though.

[@fredleckie5880]

Thank you, sir

[@awesomekling]

Hey Fred!

[@TheMrKeksLp]

I really like these browser fixing videos

[@jeremybobbin]

That was a very detailed commit message. You are very responsible.

[@zaitsev5990]

These videos are so addictive, thank you so much Andreas!

[@chairclr]

I love these videos

[@UraYukimitsu]

I'm not smart enough to do half of this but in the test, you did not pass the mime type to parseFromString

[@awesomekling]

Oh jeez you are absolutely right, thanks for pointing that out! Updated the PR 😊

[@DivjotSingh]

These videos are really inspiring!

[@msclrhd]

It would be more spec compliant to have a run method without any parameters that doesn't set the document URL. This is because the calling code set the URL. It is not a problem here, but if other places calling the parser use a different document URL (e.g. about:blank) then those will fail as implemented here.

[@coooperrr]

Would love to see some code cleanup and refactoring videos. Something very relaxing about these

[@StevenHokins]

Thank you for video ❤

[@mats66]

Hardest part.. constructing the test 🤭

[@cferreiramoura]

You missed change the mimetype in the parser string

[@Gondrux]

The mimeType in parseFromString in your test is not set correctly, you forgot to put the variable

[@cajal6]

On line 7 of your test, you accidentally hard coded text/html as the mime type. You need to set it to the mime type variable.

[@patricktorrent2721]

18:37 your forgot to put the mimetype as argument in your parseFromString function

[@evyatarshafran5017]

I would love to do some work on Ladybird! Do you have some sort of getting started video to explain some basic concepts, workflow, etc? Or should I just jump right into cloning the project, building, and letting it rip?

[@RubenKelevra]

Just jump in and find the smallest change you can make, where you have fun with :)

[@charlotteathena]

why is it the associated document of the global object and not just `this->url()` to run the DOM parser? since you already set that URL from the associated document

[@raajroy5931]

7:13 what's the font name?

[@colinstu]

Berkeley Mono

[@RubenKelevra]

What about iFrames? ;)

[@jpack61108]

Why do you write local tests when the wpt tests already cover it?

[@michaelennen3432]

Andreas did mention this in the previous video I believe - he wants to build up a local test base because the local test suite runs much faster than the full WPT test suite.

[@oren2234]

are you ok ? are you struggling with bills, why the cringe meta thumbnails lately ?

[@UAVXP]

Rude and weak. Seek for some help.

[@krolmuch]

@@UAVXP Rude and weak. Seek for some help.

[@niazhimselfangels]

I think they look better now. It's easy to know that it's his videos and easy to tell if it's a new video. 🎉

[@awesomekling]

I’m doing better than ever, just having fun with thumbnails 🤓

[@tauiin]

well thats silly