Get the source code for this video for FREE → the-dotnet-weekly.ck.page/rest-api-p2 Want to master Clean Architecture? Go here: bit.ly/3PupkOJ Want to unlock Modular Monoliths? Go here: bit.ly/3SXlzSt
That's a hot topic in my dev team right now, we are debating if we should use SignalR or C# HTTP Listener class with and encrypted inbound port and a DNS address, our system are stand alone desktop apps and not web apps, so security is a huge factor. Biggest problem with SignalR route has been a reliable way to reconnect automatically :(
I've been looking for a channel like yours for a long time and now I found it. It's your channel Milan and I'm so happy. Thank you very much for your knowledge sharing. I still have to find a good mentor on the front end like you are for me on the back end 🙏🙏🙏
On 13:19, you could create an IQueryable extension method that takes the sort order field and your expression and does the decision for OrderBy or OrderByDescending behind the scenes. Removes a bit of boilerplate code that you don't need to copy paste for each search endpoint in your API.
Also, where did you learn these techniques? I'm curious because I feel it's difficult to find good resources and tutorials that use industry standards unless you work in the industry. Or what books do you recommend to learn more about these techniques in depth?
1. I do work in the industry 😅 At least I did until this year, now I try to stay in the loop with consulting. 2. Pluralsight has a lot of good resources for .NET, to be honest. Courses from Kevin Dockx about APIs cover all of this in much more detail.
A few years ago I used a library for parsing OData query options called Moon.OData. I could send an OData query and the program translated it into a normal t-sql. Very simple and safe for both user and developer. I believe there are more such libraries nowadays. Would definitely recommend that to anyone.
Excellent video! Really helpful! Thanks for sharing! by the way, can you explain in a short video format the record and sealed modifiers from your perspective and it's importance the documentation not consider optimization benefits. Thanks
I had to create something similar but the backend DB was Mongo so I had to use projection, and for the search I used reflection to get the Data Annotation for the BsonElement name and type, the documents had over 150 fields ... It would be nice to add reflection to this tutorial to avoid hard coding the name of the properties, maybe using JsonProperty annotation??? Thanks for the great tutorial
Thanks for sharing this insightful, in all my api projects i use rye same logic for paging, filtering and sorting. For the pagination i return an object that contains items page number and page size as you did, however instead of returning a boolean HasNextPage or HasPreviousPage, i return string which are url for the previous and next pages already prepared (when i'm one the first page, previous page is null and if i'm in the last page next page is gonna be null )so in case one of clients of my api is working on a batch for frtching data url are already prepared by the api 😃 Thanks for sharing i really like your helpful content
I loved the Expression with switch to cover the which column to sort by, in my project I have the same amount of search choices I want to cover, so I'm using if else statements, can you please show case or at least right here as a respond an Expression with switch that is used in Where() instead of OrderBy(). I tried it but I'm messing something and i can't get it to work. Thanks a lot for the video, it helped a lot
Hi! again, I'm glad with your nice explanation! But I have a cuple of questions, what about create queries (with pagination as you show us) with multiples tables in our database? and by the other hand, what do you think about the EF against the Dapper performance?
Thank you for covering those topics which are helpful in handling performance issues. On filtering, if the table has multiple columns, then the number of parameters may grow. is there a generic way to easily achieve it. On pagination, if the result fits in 5 pages, the client should call the API for 5 times. So, the end query will be executed 5 times by considering the page number. will it not affect the sql performance
For filtering u need to use reflection and build your own - use queryable, there is no in-built solution. For pagination u should add some kind of limit parameter which could be set to number representing numbers of records on each page (Skip + Take)
I highly suggest you determine a maximum page size and use that instead of what the client is requesting if their pagesize exceeds your maximum. :) Also, I think I like returning the pagination information in headers, rather than in the response payload.
Whoops, missed to mention that! But yeah, that's important to consider. (Can't say I never tried to harass some APIs by seeing if they had a max_page_size on the backedn 😅)
Thanks for the great video, I've followed your clean architecture course which is great too. I'm building a project off the back of that and wondering how you've structured the IApplicationDbContext interface here to use directly in the handler as oppose to a repository interface as the DbContext is in the infrastructure layer. How is this interface being registered in the DI container? Do you have any code examples of what that interface could look like?
Does the select hurt performance of the take, skip, or count async? Calling ToListAsync is when the queryable is actually executed but how does it know to reorder the operations in a performant way?
No, EF doesn't execute anything until the ToList call - it's only then that everything is assembled into a SQL query so it know how to re-order them to achieve the optimal result
Thank you for the quality content I have a question. For sorting and searching why didnt you use reflection to search or sort in every column. Also if you add new fields you dont need to add new contains to the where part.
It seems like a good tutorial but I am having difficulty following your architecture and stuff about record and sku. Are there any prior videos that I need to watch? This has been happening to me for quite a few videos so any help in that will be very appreciated.
Good question @joseantonio Please can you explain what you mean by break the architecture. @MilanJovanovicTech I recently worked on a project where I fetched data as queryables. I did this by creating the interface for each entities' repository in the application layer and then implementing it in the infrastructure layer. Do you have a better way to achieve this.
Is there a standard way for adding specific/complex filters? For example, filtering by a date interval or a price range. Creating this in a generic way to be reused in several endpoints
LinqKit has a PredicateBuilder. We add attributes to our search parameter properties that defines what and how comparisons should be applied on what on the search result. Ours handles standard ones, exact, like, ranges, enum matching, lists, nullables, etc. Should be possible to find a start on google.
Hi Milan, thank for the video. are you going to refactor the sorting method to be extension method and generic? var list =await context .Users .OrderDescendingByField(nameof(User.Name)) // OrderByField for asc .ToListAsync();
Can I return the PagedList with a list of domain models from the repository and map it in a query handler to a PagedList of DTOs to send as a response?
@MilanJovanovicTech thanks for your reply. I am actually trying to implement pagination and sorting in sql query but i dont seem to find the best approach. The main problem is sorting as they mainly recommend to have a massive switch statement with a case for every column in the table or i have to write a dynamic query but have the risk of sql injection as the column name param is coming from front end. Thanks.
This is good stuff. EF is fine when returning simple entities from the DB. At 13:46 I would have taken the refactoring a little further and eliminate the "8-liner" (as I like to to call those if..else pairs that simply assign a variable) with the ternary operator. I'm not a fan the PageList stuff, returning the TotalCount is a very expensive choice with, IMO, limited value. Whether there is a previous or next page is of even less value. (E.g. I know I just got page 1 so I don't really need the server to tell me there isn't a previous page and for reasonable page sizes (say 20) 95% of the time I can tell there is no next page because the count of results returned is < pageSize). I prefer the simplicity of just returning the set of results but I guess it is down to your specific use cases.
@@davearkley7014 Were you filtering a text value using a contains predicate? How many concurrent users are also demanding an extra 86ms of DB servers' time? That's huge right?
@@nothingisreal6345 No that still will not be "ok". Pretty sure it does do that and without any criteria the DB could respond with internal stats it maintains, it won't have to actually count records. However, if you are using say a Name Like '%' + term + '%' its going have to do a table scan, and search each string. Considering the use case for this feature is pretty weak to start with, I personally don't include this in my designs.
@@MilanJovanovicTech let's say you have a Shop (aggregate root) which has N employees and you want to get api/shop/{shopId)/employees?page=1&pageSize=10
At 21:02 aren't you performing the query twice at the DB level? Once to get the `totalCount` and a second one to get `items`? If so, how can we avoid this?
Thank you for useful video! I was wondering, whether we are able to create generic method for sorting not only for the specific class, but for all entites. Is it possible to do in correct way? Because I tried and it looks like sh!t)
@@MilanJovanovicTech for now, I used specification pattern. Was inspired by your previous video). In my test assignment I receive sorting and paging via query parameters, which can be null. Therefore I decided to create specification inheritor from base specification. And IN RUNTIME apply different things, like sorting by column name and so on to it. It is not predefined like you shown in the video. What do you think about this. Is this a good approach? Thank you for reply :)
With paged list it's easy to fetch current page / count all records. But how would you build generic filtering with different entity types? I'm sure we can come up with some abstraction to provide the desired filter and sorting. But is it worth it?
@@MilanJovanovicTech Yes was wondering about that since orderby and filtering dont look if i may say appealing to me but as you say its not worth it to go that deep in abastraction
You could do sorting using dynamic linq public static IQueryable SetOrdering(this IQueryable query, string orderColumn, string orderingDirection) { if (string.IsNullOrEmpty(orderColumn)) { return query; } return query.OrderBy($"{orderColumn.Trim()} {orderingDirection.Trim().ToLower()}"); } Ofc column and sort order would be validated in validation step
I have a question, you are getting all the products with context.Products, if I have 5000 items it gets them all and then you are applying the filtering. Therefore the filter would not make sense because the objects are being loaded into memory and then the paging is applied. I have a doubt, thank you
Milan, but when I debug the IQueryable already has all the results, without the TolistAsync, why does this happen?, I am waiting for your answer, thanks
@@cristhianjuliancubides6269 Probably because debugger triggers the evaluation of the iqueryable so you can see the results. Are you sure you don't click something like "show me the results (this will force the enumeration)"?
How about use approach which use only 3 models it's: PaginationOptions, SortingOptions, FilteringOptions and use enum instead string in case sorting for example, it's make code more cleaner and remove reducant parameter, I wish to know how to implement this thank, you, I can share the post in LinkedIn where I find it
Actually what you did there is very bad. The much better solution in to make thing more generic by create more interfaces and base query handlers. Also, way you doing sorting is ugly. You can just use reflection and make it work with whatever object you like without any problem. I created such generic mechsnism in my project using cqrs and efcore and developers who are using it loves that you can add new lists in just minute by inheriring some base generic classess
@@MilanJovanovicTech Don't mind him! Your content was pretty good! No reflection means better speed, base classes and generic interfaces may be needed if you were to craft a general-purpose lib such as Sieve or AutoQueryable, but what you demonstrated simply allows anyone aiming at this goal to get started and generalize any way they'd like What's more, promoting heavily layered and generic architecture is at the very least debatable (Heard of the heated debate between cmuratori and uncle Bob of "clean code" fame? One comes from the native video game world where performance is paramount, the other is a book-author consultant who goes full with DI, virtual dispatching and OO patterns). From bare-bone C-like code to 50-layer architectures there's a middle ground, but I must admit that, age helping, I'm leaning more and more towards the less abstraction side (and I've been professionally using C# for 20y now) Simply said, there's nothing in this video you'd have to feel ashamed of. Even as a senior dev, I found inspiration here for my own use cases!
@@OlivierDALET Thanks a lot, I appreciate it. I'm not really a junior, just messing with OP a little. I do tend to not overcomplicate my videos, and let the viewer find what value he can and take it from there into their own implementation. If they choose to make it more complex and entirely generic, that's great for them.
Get the source code for this video for FREE → the-dotnet-weekly.ck.page/rest-api-p2
Want to master Clean Architecture? Go here: bit.ly/3PupkOJ
Want to unlock Modular Monoliths? Go here: bit.ly/3SXlzSt
That's a hot topic in my dev team right now, we are debating if we should use SignalR or C# HTTP Listener class with and encrypted inbound port and a DNS address, our system are stand alone desktop apps and not web apps, so security is a huge factor.
Biggest problem with SignalR route has been a reliable way to reconnect automatically :(
I've been looking for a channel like yours for a long time and now I found it. It's your channel Milan and I'm so happy. Thank you very much for your knowledge sharing. I still have to find a good mentor on the front end like you are for me on the back end 🙏🙏🙏
Welcome!
On 13:19, you could create an IQueryable extension method that takes the sort order field and your expression and does the decision for OrderBy or OrderByDescending behind the scenes. Removes a bit of boilerplate code that you don't need to copy paste for each search endpoint in your API.
I know, that could've been the next step
Man You Dont Know How Valueble These Comments are And Its Great Idea im gonna Do It Rn xD
Thanks for this awesome video.I was searching from long time 😊.
Most welcome 😊
Great, in-detail tutorial!
Thanks, bro!
Your videos are SO good! Thank you for teaching me so much!
Also, where did you learn these techniques? I'm curious because I feel it's difficult to find good resources and tutorials that use industry standards unless you work in the industry. Or what books do you recommend to learn more about these techniques in depth?
1. I do work in the industry 😅 At least I did until this year, now I try to stay in the loop with consulting.
2. Pluralsight has a lot of good resources for .NET, to be honest. Courses from Kevin Dockx about APIs cover all of this in much more detail.
Milan, this was a very useful video tutorial. thx a lot
Glad it was helpful!
A few years ago I used a library for parsing OData query options called Moon.OData. I could send an OData query and the program translated it into a normal t-sql. Very simple and safe for both user and developer.
I believe there are more such libraries nowadays. Would definitely recommend that to anyone.
Pretty cool!
Excellent as usual Milan 👌
Thanks a lot!
thans alot, this was very useful .🙏🙏
Don't mention it. I'm here to provide value :)
Bravo doktore 🤝
Hvala puno! 😁
Excellent video! Really helpful! Thanks for sharing! by the way, can you explain in a short video format the record and sealed modifiers from your perspective and it's importance the documentation not consider optimization benefits. Thanks
Ahh good idea for some shorts :)
Have you already done a full tutorial on your channel? I like your teaching style! I wish there is a full tutorial or even a course
There's another video for CRUD endpoints
@@MilanJovanovicTech I mean a full tutorial from the beginning (Include the setup). This is for us beginners 😁
Waiting for the Dapper version too! Great video.
Hah! That would actually be interesting! Adding it to my video backlog 💥
Where should I put the PagedList model? In the domain layer or in the application?
Shared kernel
Great! Thanks Milan ❤
You bet!
I had to create something similar but the backend DB was Mongo so I had to use projection, and for the search I used reflection to get the Data Annotation for the BsonElement name and type, the documents had over 150 fields ... It would be nice to add reflection to this tutorial to avoid hard coding the name of the properties, maybe using JsonProperty annotation??? Thanks for the great tutorial
That would be a nice improvement, agreed
Thanks for sharing this insightful, in all my api projects i use rye same logic for paging, filtering and sorting. For the pagination i return an object that contains items page number and page size as you did, however instead of returning a boolean HasNextPage or HasPreviousPage, i return string which are url for the previous and next pages already prepared (when i'm one the first page, previous page is null and if i'm in the last page next page is gonna be null )so in case one of clients of my api is working on a batch for frtching data url are already prepared by the api 😃
Thanks for sharing i really like your helpful content
HATEOAS, that's smart! I didn't want to introduce that as I thought it would be too much, but I might just prepare that for the next video
Hello that's really good can you share the code for it ?
Wonderful. Thanks ❤
Thank you too!
We want the Dapper version too.
I see there's demand for it, already added it to my backlog 😁
I loved the Expression with switch to cover the which column to sort by, in my project I have the same amount of search choices I want to cover, so I'm using if else statements, can you please show case or at least right here as a respond an Expression with switch that is used in Where() instead of OrderBy(). I tried it but I'm messing something and i can't get it to work. Thanks a lot for the video, it helped a lot
You need Expression
Hi! again, I'm glad with your nice explanation!
But I have a cuple of questions, what about create queries (with pagination as you show us) with multiples tables in our database?
and by the other hand, what do you think about the EF against the Dapper performance?
Use whichever ORM you like 😁
And what about create endpoints?
I was expecting something more generic like Sieve for automatic pagination sorting and filtering.
Or OData or graph
Sometimes it's worthwhile to know the fundamentals
Thank you for covering those topics which are helpful in handling performance issues.
On filtering, if the table has multiple columns, then the number of parameters may grow. is there a generic way to easily achieve it.
On pagination, if the result fits in 5 pages, the client should call the API for 5 times. So, the end query will be executed 5 times by considering the page number. will it not affect the sql performance
For filtering u need to use reflection and build your own - use queryable, there is no in-built solution. For pagination u should add some kind of limit parameter which could be set to number representing numbers of records on each page (Skip + Take)
You can achieve most of it with reflection, and there's even a cool library out there called Dynamic.Linq
I highly suggest you determine a maximum page size and use that instead of what the client is requesting if their pagesize exceeds your maximum. :)
Also, I think I like returning the pagination information in headers, rather than in the response payload.
Whoops, missed to mention that! But yeah, that's important to consider. (Can't say I never tried to harass some APIs by seeing if they had a max_page_size on the backedn 😅)
How would having pagination information within hdeaders benefit? Is it common?
@@shahryarsaljoughi6073 I prefer keeping paging out of the query string which I reserve for filters.
Thanks for the great video, I've followed your clean architecture course which is great too. I'm building a project off the back of that and wondering how you've structured the IApplicationDbContext interface here to use directly in the handler as oppose to a repository interface as the DbContext is in the infrastructure layer. How is this interface being registered in the DI container? Do you have any code examples of what that interface could look like?
services.AddDbContext(_rest of ef config_);
You can use this overload 👆
Ahhhh .... you are amazing
Thank you!
Hi Milan, tks for the video. It would be great if you could make a video on the Expression that you created? I could not wrap my head around that.😂
Ah, sorry about that. It's an EF trick I use from time to time. I'll see what I can do
@@MilanJovanovicTech thanks Milan. What is the keyword of this Expression? i wanna search it up first
OMG you're the man! Thanks
Sure thing! :)
Any thoughts on creating a tutorial for Cursor Pagination or any other types along with explaining the benefits of the same? As always great videos. 😇
I already made a video on Cursor pagination
Does the select hurt performance of the take, skip, or count async? Calling ToListAsync is when the queryable is actually executed but how does it know to reorder the operations in a performant way?
No, EF doesn't execute anything until the ToList call - it's only then that everything is assembled into a SQL query so it know how to re-order them to achieve the optimal result
Thank you for the quality content I have a question. For sorting and searching why didnt you use reflection to search or sort in every column. Also if you add new fields you dont need to add new contains to the where part.
I find this approach more explicit, so that's why. You could've also done it with reflection, but it would've been a lot more cumbersome.
normally you apply indexes to search columns
Thanks for the tutorial and great video, Is there a series for this video?
Yes:
1) ruclips.net/video/nE2MjN54few/видео.html
2) ruclips.net/video/X8zRvXbirMU/видео.html
3) ruclips.net/video/59Ce4O3J7Do/видео.html
@@MilanJovanovicTech thank you milan
Could you show us how to implement the sorting if we are using generic classes and we don't know the class attributes before runtime?
You'd need a "smart" mechanism to standardize it, and you'll probably end up using reflection or something similar
Thank you, very helpful. Nice clean coding as well 👍
Thanks! Glad you liked it :)
It seems like a good tutorial but I am having difficulty following your architecture and stuff about record and sku. Are there any prior videos that I need to watch? This has been happening to me for quite a few videos so any help in that will be very appreciated.
Check out the playlists
Really helpful 😊
Which machine are you using for editing and recoding? Specs
Thanks 👍
Ryzen 7-based machine, RTX 3060, pretty solid setup.
@@MilanJovanovicTech are you using liquid cooling or air cooling for pc ?
Great video as usual. Any chance of an Odata tutorial?
I haven't used it in Production, so I'll see if I can find some time to research it
The issue on 06:00 is it because of value object thing having setup with valueConverters? I run into this issue a few times.
Yeah, precisely why
Great video, but I have a question: is it possible to reference the DBContext from the application layer with a clean architecture?
It's possible - but it "breaks" the architecture
Good question @joseantonio
Please can you explain what you mean by break the architecture. @MilanJovanovicTech
I recently worked on a project where I fetched data as queryables. I did this by creating the interface for each entities' repository in the application layer and then implementing it in the infrastructure layer.
Do you have a better way to achieve this.
Could you make implicit operator for Sku, so we will remove type casting and just use Sku where string is expected?
EF has to know that you want it to be a string and not a Sku :/
A better approach in my opinion since it is a value object is to use a EF Converter... Sku.HasConversion... I think it is.
Why you didn’t use graphql with EF Core ?
REVERSE: Why SHOULD I use it in the first place?
Hi, what if in page 2 and tried to search an item available in page 1 do I still get that item? Or every search is need to reset the pageNumber to 1?
You'd get what matches that search - but on page 2
Is there a standard way for adding specific/complex filters? For example, filtering by a date interval or a price range. Creating this in a generic way to be reused in several endpoints
Search for odata
Unless you'll be using it in quite a few endpoints, it's probably not worth it implementing a custom abstraction
LinqKit has a PredicateBuilder. We add attributes to our search parameter properties that defines what and how comparisons should be applied on what on the search result. Ours handles standard ones, exact, like, ranges, enum matching, lists, nullables, etc. Should be possible to find a start on google.
@@alanbreeeeDoes OData work with the Minimal API?
How do you rate Biarity Sieve for Sorting , Filtering and Pagination? although it has some challenges for VO or complex types
I can't rate it since I never used it 🤷♂️
I love that library and other one which i use is Gridify
How would you do dynamic select/projection?
I'd say only if you're not used to the second approach. We can argue for both approaches, if we want to
Hi Milan, thank for the video.
are you going to refactor the sorting method to be extension method and generic?
var list =await context
.Users
.OrderDescendingByField(nameof(User.Name)) // OrderByField for asc
.ToListAsync();
Yeah, could be doable - not planning on it. But perhaps with reflection.
System.Linq.Dynamic.Core makes it possible to just order by a string, a little easier but will need to check if the column is valid in some other way,
Can I return the PagedList with a list of domain models from the repository and map it in a query handler to a PagedList of DTOs to send as a response?
Too much overhead, no?
can you post the result query generated by EF? It would be nice to know how its being done in Sql Server.
Will try if I can find some time - but nothing special, just your standard WHERE/ORDER BY/OFFSET query
@MilanJovanovicTech thanks for your reply. I am actually trying to implement pagination and sorting in sql query but i dont seem to find the best approach. The main problem is sorting as they mainly recommend to have a massive switch statement with a case for every column in the table or i have to write a dynamic query but have the risk of sql injection as the column name param is coming from front end. Thanks.
This theme looks beautiful can you provide me the name of it... and Thank for the tutorial Learned alot from you
ReSharper syntax highlighting
This is good stuff. EF is fine when returning simple entities from the DB. At 13:46 I would have taken the refactoring a little further and eliminate the "8-liner" (as I like to to call those if..else pairs that simply assign a variable) with the ternary operator.
I'm not a fan the PageList stuff, returning the TotalCount is a very expensive choice with, IMO, limited value. Whether there is a previous or next page is of even less value. (E.g. I know I just got page 1 so I don't really need the server to tell me there isn't a previous page and for reasonable page sizes (say 20) 95% of the time I can tell there is no next page because the count of results returned is < pageSize). I prefer the simplicity of just returning the set of results but I guess it is down to your specific use cases.
>> returning the TotalCount is a very expensive choice
An extra 86ms on my desktop machine with a 1000000 row table
@@davearkley7014 Were you filtering a text value using a contains predicate? How many concurrent users are also demanding an extra 86ms of DB servers' time? That's huge right?
I had the same idea reg ternary operator.
I would need to check if EF converts the CountAsync into SELECT COUNT(*) FROM (
@@nothingisreal6345 No that still will not be "ok". Pretty sure it does do that and without any criteria the DB could respond with internal stats it maintains, it won't have to actually count records.
However, if you are using say a Name Like '%' + term + '%' its going have to do a table scan, and search each string. Considering the use case for this feature is pretty weak to start with, I personally don't include this in my designs.
How would you approach a case where you need to paginate child entites of an aggregate?
How would that work from an API consumer perspective?
@@MilanJovanovicTech let's say you have a Shop (aggregate root) which has N employees and you want to get api/shop/{shopId)/employees?page=1&pageSize=10
At 21:02 aren't you performing the query twice at the DB level? Once to get the `totalCount` and a second one to get `items`? If so, how can we avoid this?
This is a typical issue with this type of pagination. You could write SQL and a batched query that would fetch both values in one round trip.
Thank you for useful video! I was wondering, whether we are able to create generic method for sorting not only for the specific class, but for all entites. Is it possible to do in correct way? Because I tried and it looks like sh!t)
Yes you can! What does it look like?
@@MilanJovanovicTech for now, I used specification pattern. Was inspired by your previous video). In my test assignment I receive sorting and paging via query parameters, which can be null. Therefore I decided to create specification inheritor from base specification. And IN RUNTIME apply different things, like sorting by column name and so on to it. It is not predefined like you shown in the video. What do you think about this. Is this a good approach? Thank you for reply :)
Is there a way to set up filtering and orderby to be like pagedlist generic?
With paged list it's easy to fetch current page / count all records. But how would you build generic filtering with different entity types?
I'm sure we can come up with some abstraction to provide the desired filter and sorting. But is it worth it?
@@MilanJovanovicTech Yes was wondering about that since orderby and filtering dont look if i may say appealing to me but as you say its not worth it to go that deep in abastraction
You could do sorting using dynamic linq
public static IQueryable SetOrdering(this IQueryable query,
string orderColumn, string orderingDirection)
{
if (string.IsNullOrEmpty(orderColumn))
{
return query;
}
return query.OrderBy($"{orderColumn.Trim()} {orderingDirection.Trim().ToLower()}");
}
Ofc column and sort order would be validated in validation step
I used that library before, works pretty well
I have a question, you are getting all the products with context.Products, if I have 5000 items it gets them all and then you are applying the filtering. Therefore the filter would not make sense because the objects are being loaded into memory and then the paging is applied.
I have a doubt, thank you
No, the first is just an IQueryable and it doesn't touch the database until we call ToListAsync
Milan, but when I debug the IQueryable already has all the results, without the TolistAsync, why does this happen?, I am waiting for your answer, thanks
@@cristhianjuliancubides6269 Probably because debugger triggers the evaluation of the iqueryable so you can see the results. Are you sure you don't click something like "show me the results (this will force the enumeration)"?
17:22 "by incrementing the page *number" 😉
Happens 😁
How about use approach which use only 3 models it's: PaginationOptions, SortingOptions, FilteringOptions and use enum instead string in case sorting for example, it's make code more cleaner and remove reducant parameter, I wish to know how to implement this thank, you, I can share the post in LinkedIn where I find it
All improvements
Sorting input can be a bit better using enum string.
That's a nice approach
How to view MVC with it 🤔? I was trouble
Haven't used that in ages
With Dapper?
I'm using EF Core here
I use a nuget package called sieve to does this .
Oh cool, let me check that out
@@MilanJovanovicTech Yes , please let us know your thought about this 🙂
Why not GrapaQL?
Why _would_ it be GraphQL?
will that work with .net 6?
Yes
Source code needed
I share it on Patreon
with OData, you dont need to do all implementation by youself.
It's good to know the fundamentals
Actually what you did there is very bad. The much better solution in to make thing more generic by create more interfaces and base query handlers. Also, way you doing sorting is ugly. You can just use reflection and make it work with whatever object you like without any problem. I created such generic mechsnism in my project using cqrs and efcore and developers who are using it loves that you can add new lists in just minute by inheriring some base generic classess
I'm still a junior engineer, don't be so rude
@@MilanJovanovicTech you are junior? Though you are senior who create content for less experienced devs. Sorry then.
@@MilanJovanovicTech Don't mind him! Your content was pretty good!
No reflection means better speed, base classes and generic interfaces may be needed if you were to craft a general-purpose lib such as Sieve or AutoQueryable, but what you demonstrated simply allows anyone aiming at this goal to get started and generalize any way they'd like
What's more, promoting heavily layered and generic architecture is at the very least debatable (Heard of the heated debate between cmuratori and uncle Bob of "clean code" fame? One comes from the native video game world where performance is paramount, the other is a book-author consultant who goes full with DI, virtual dispatching and OO patterns). From bare-bone C-like code to 50-layer architectures there's a middle ground, but I must admit that, age helping, I'm leaning more and more towards the less abstraction side (and I've been professionally using C# for 20y now)
Simply said, there's nothing in this video you'd have to feel ashamed of. Even as a senior dev, I found inspiration here for my own use cases!
@@OlivierDALET Thanks a lot, I appreciate it. I'm not really a junior, just messing with OP a little. I do tend to not overcomplicate my videos, and let the viewer find what value he can and take it from there into their own implementation. If they choose to make it more complex and entirely generic, that's great for them.
Too much coding to deliver such a simple standard feature. I have a library that does this and much more without any coding.
Sometimes it's good to know the fundamentals, instead of reaching for a library for everything
What is your story?
💥💥