Комментарии •

  • @crandelzet573
    @crandelzet573 3 года назад

    Good video. Thank you for speaking so clearly without slang.
    Mainly for those of us who do not usually hear English

    • @LondonAppDeveloper
      @LondonAppDeveloper 3 года назад

      You're welcome sir, thank you for watching and for the feedback.

  • @mrhoxell
    @mrhoxell 6 лет назад +4

    Simple and great explanation. Thanks

  • @dmmm876
    @dmmm876 6 лет назад +2

    Great video. Perfect level of detail and well explained.

  • @davidbarbaran7796
    @davidbarbaran7796 5 лет назад +1

    Perfect video, clear and concise points! Keep it up

  • @MrRoblox9000
    @MrRoblox9000 3 года назад

    Very crisp and neat .. great explanation

  • @cwcfunclock2709
    @cwcfunclock2709 Год назад

    Thank you for teaching me. It's really helpful.

  • @vtvvnha2230
    @vtvvnha2230 7 лет назад +1

    Love the way you explain things :), a great video

  • @HamzaKhan-wi9kb
    @HamzaKhan-wi9kb Год назад

    Very important things missed, like if someone asks you to make some changes then how do you do that and how does it reflect back in the pull request.

  • @braimahhassanoshiapemhe6430
    @braimahhassanoshiapemhe6430 3 года назад

    Great stuff, very concise and rich in content

  • @VishalTheK
    @VishalTheK 2 года назад

    Greatly explained

  • @tejkumarkempaiah4906
    @tejkumarkempaiah4906 4 года назад +1

    Awesome explanation, Thank you!

  • @vilasackphothisan4839
    @vilasackphothisan4839 4 года назад +1

    If I have a feature branch, is it a good practice to merge development down to the feature branch before the code review or any code compare?

  • @ankitaburman5406
    @ankitaburman5406 2 года назад

    Amazing video explained in great detail ❤️❤️❤️❤️❤️

  • @ntsystem
    @ntsystem 5 лет назад +1

    Question, is it possible to do this code review on a standalone git server and not using third party such as github or bitbucket? If so, can anyone link me to the right resources?
    Thanks :)

  • @omarpalauavila6962
    @omarpalauavila6962 Год назад

    I think a very important thing missed in this video is how to get a commit down to your machine locally, otherwise, how can you review stuff?

  • @abdelaziznassif3845
    @abdelaziznassif3845 4 года назад +1

    Great Video

  • @MrSegagraff
    @MrSegagraff 4 года назад

    Nice video, It would be helpful to teach people also how to set Develop branch as default. So each pull request will have to develop branch as default.

  • @JohnSan14
    @JohnSan14 7 лет назад +1

    Great video and some excellent points! What are your thoughts on pair programming?

    • @JR-mk6ow
      @JR-mk6ow 4 года назад

      not essential. peer reviews are the norm now

  • @tharangopal2911
    @tharangopal2911 5 лет назад

    I often find it hard to navigate when multiple round of reviews. Can you show me how to navigate in that case

  • @thevipinchand4690
    @thevipinchand4690 6 лет назад

    Great explanation. Thanks

  • @ashishashish503
    @ashishashish503 3 года назад

    really helpful.

  • @nebyuwinis
    @nebyuwinis 3 года назад

    great vid thank you

  • @_tauqeerahmad
    @_tauqeerahmad Год назад

    Perfect

  • @dagysteinjohansen7268
    @dagysteinjohansen7268 4 года назад

    What if you are peerless?

    • @LondonAppDeveloper
      @LondonAppDeveloper 4 года назад +1

      Good question :) I am often peerless but I follow the pull request process nonetheless. It's a useful habit to cultivate. I always review my own code before merging just to give it a second look.

  • @RainBringer
    @RainBringer 2 года назад

    Many aspects of the topic weren't covered. For example, what happens after finding bug and commenting? How the PR author fixes and resolves the issue? How the reviewer sees the fix and the comparison of the fixed file version to the original one? Etc. Very shallow tutorial.

  • @mrxinu
    @mrxinu 5 лет назад

    Excellent explanation! Thank you!